Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pe rich header #375

Merged
merged 12 commits into from
Sep 20, 2021
Merged

Pe rich header #375

merged 12 commits into from
Sep 20, 2021

Conversation

daladim
Copy link
Contributor

@daladim daladim commented Sep 10, 2021

This is a first attempt at resolving #339 .

There is still a part that needs implementation, and I myself have a few questions for you in the comments of this pull request

daladim
daladim commented Sep 10, 2021
View reviewed changes
philipc
philipc requested changes Sep 10, 2021
View reviewed changes
philipc
philipc requested changes Sep 17, 2021
View reviewed changes
philipc
philipc reviewed Sep 17, 2021
View reviewed changes
philipc
philipc approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FYI I'll do a follow up PR with readobj support and some small style changes.

@philipc philipc merged commit 27f097a into gimli-rs:master Sep 20, 2021
mcbegamerxx954 pushed a commit to mcbegamerxx954/object that referenced this pull request Jun 15, 2024
@daladim
read/pe: rich header (gimli-rs#375)
1d8366a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daladim @philipc